Sat Nov 19 01:26:11 2005

Ticket #1534 (Closed: fixed)

image manager broken


Priority: normal Reporter: [email protected]
Severity: minor Assigned to: paul
Component: Article Editing Status: closed
Version: 2.3.3 Resolution: fixed
Milestone: 2.4.0 Keywords:  

Description by [email protected]:

For me on firefox 1.0.7 ImageManager? raises a javascript bug when I select on an image. This is because the generated javascript had no width or height included when calling selectImage.

I "fixed" it by editing: javascript/xinha/plugins/ImageManager-xinha/images.php javascript/xinha/plugins/ImageManager/images.php

to change from: <?php echo $file['image'][0];?>, <?php echo $file['image'][1]; ?> to <?php echo 0+$file['image'][0];?>, <?php echo 0+$file['image'][1]; ?>

Of course it begs the question as to why $file['image'][0] and [1] were unset anyway, and even if defaulting to 0 is safe, but it "works for me".

I also get ??? displayed as the caption below each image in the image-picker, is this right?

Sam

Changelog

Sat Nov 19 10:26:16 2005: Modified by mugur

  • milestone changed from 2.4.0 to 2.3.4
  • owner changed from anonymous to paul

Fri Dec 2 21:02:02 2005: Modified by paul

  • milestone changed from 2.3.4 to 2.4.0

Tue Dec 6 21:57:37 2005: Modified by paul

  • resolution set to fixed
  • status changed from new to closed

Thanks for the patch! I applied it in changeset:4132.