Ticket #1424 (Closed: fixed)

Unfortunately I can't reproduce it. I've uploded here two files with XMLRPC request related to your post - what's the difference between them and your requests? (files may be directly used as XMLRPC request after update of sessid field)

is this still an issue?

The problem seems to be the <string> tag, which is omitted by the XML-RPC package used by the C++ components.

This works:

<member><name>criteria</name><value>
   <struct>
    <member>
     <name>conditions</name>
     <value><array><data>
      <value><struct>
       <member><name>cat</name><value><string>dc:title</string></value></member>
       <member><name>op</name><value><string>partial</string></value></member>
       <member><name>val</name><value><string/></value></member>
      </struct></value>
      <value><struct>
       <member><name>cat</name><value><string>dc:creator</string></value></member>
       <member><name>op</name><value><string>partial</string></value></member>
       <member><name>val</name><value><string/></value></member>
      </struct></value>
      <value><struct>
       <member><name>cat</name><value><string>dc:source</string></value></member>
       <member><name>op</name><value><string>partial</string></value></member>
       <member><name>val</name><value><string/></value></member>
      </struct></value>
     </data></array></value>
    </member>
    <member><name>filetype</name><value><string>all</string></value></member>
    <member><name>operator</name><value><string>or</string></value></member>
   </struct>
  </value></member>

But this does not work (although it used to):

<member><name>criteria</name><value>
 <struct>
  <member>
   <name>conditions</name>
   <value><array><data>
    <value><struct>
     <member><name>cat</name><value>dc:title</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value></value></member>
    </struct></value>
    <value><struct>
     <member><name>cat</name><value>dc:creator</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value></value></member>
    </struct></value>
    <value><struct>
     <member><name>cat</name><value>dc:source</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value></value></member>
    </struct></value>
   </data></array></value>
  </member>
  <member><name>filetype</name><value>all</value></member>
  <member><name>operator</name><value>or</value></member>
 </struct>
</value></member>

... and by "does not work", I mean that it returns a normal-looking answer, but with 0 results:

<methodResponse>
 <params>
  <param>
   <value><struct>
    <member>
     <name>audioClipCnt</name>
     <value><int>0</int></value>
    </member>
    <member>
     <name>playlistCnt</name>
     <value><int>0</int></value>
    </member>
    <member>
     <name>audioClipResults</name>
     <value><array>
      <data>
      </data>
     </array></value>
    </member>
    <member>
     <name>playlistResults</name>
     <value><array>
      <data>
      </data>
     </array></value>
    </member>
   </struct></value>
  </param>
 </params>
</methodResponse>

... but if the search is not empty, it works fine without the <string> tag. For example,

<member><name>criteria</name><value>
 <struct>
  <member>
   <name>conditions</name>
   <value><array><data>
    <value><struct>
     <member><name>cat</name><value>dc:title</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value>a</value></member>
    </struct></value>
    <value><struct>
     <member><name>cat</name><value>dc:creator</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value>a</value></member>
    </struct></value>
    <value><struct>
     <member><name>cat</name><value>dc:source</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value>a</value></member>
    </struct></value>
   </data></array></value>
  </member>
  <member><name>filetype</name><value>all</value></member>
  <member><name>operator</name><value>or</value></member>
 </struct>
</value>

returns the records one would expect it to.

Huh - it's bug in PEAR XML-RCP module - if there is empty <value></value> tag, it's not interpreted as empty string (as it should according to XML-RPC spec.), but some orphaned object instead. I will try to fix it, but it probably will be later than 1.0.1 release.

Fortunately the fix for this bug is contained in newer version of PEAR XML_RPC module.

I've upgraded it.

It still does not work for me. I did

svn update
make -C modules/storageServer pear_install
make recompile

but still get 0 results for an empty search without the <string> tag.

Is there anything else I need to do?

Ooops - there is little inconsitency. For now use: make -C modules/storageServer pear_setup_devel

(packages installed by pear_install target are not used in devel.env. now)

I will make the devel.env. setup consistent with normal one.

No, sorry, still doesn't work. The version with <string> is still OK, but now the <string>-less version gives me an error message:

<?xml version="1.0" encoding="UTF-8"?>
<methodResponse>
<fault>
<value>
<struct>
<member>
<name>faultCode</name>
<value><int>804</int></value>
</member>
<member>
<name>faultString</name>
<value><string><br />
<b>Fatal error</b>:  Call to a member function on a non-object in <b>/home/fgerlits/src/livesupport/tools/pear/tmp/lib/pear/XML/RPC.php</b> on line <b>1856</b><br />
</string></value>
</member>
</struct>
</value>
</fault>
</methodResponse>

Unfortunately I can't reproduce it. Send me complete XMLRPC request, please.

Thanks.

Yes, it's interesting... If I send the xml-rpc request with line breaks, like this:

POST /~fgerlits/livesupport/storageServer/var/xmlrpc/xrLocStor.php HTTP/1.1
User-Agent: XMLRPC++ 0.8
Host: localhost:80
Content-Type: text/xml
Content-length: 1234
<?xml version="1.0"?><methodCall><methodName>locstor.searchMetadata</methodName><params><param><value><struct>
<member><name>criteria</name><value>
 <struct>
  <member>
   <name>conditions</name>
   <value><array><data>
    <value><struct>
     <member><name>cat</name><value>dc:title</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value></value></member>
    </struct></value>
    <value><struct>
     <member><name>cat</name><value>dc:creator</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value></value></member>
    </struct></value>
    <value><struct>
     <member><name>cat</name><value>dc:source</value></member>
     <member><name>op</name><value>partial</value></member>
     <member><name>val</name><value></value></member>
    </struct></value>
   </data></array></value>
  </member>
  <member><name>filetype</name><value>all</value></member>
  <member><name>operator</name><value>or</value></member>
 </struct>
</value></member>
<member>
 <name>sessid</name>
 <value>5095aa18b26b79f292b95d565a0d6c2b</value>
</member>
</struct></value></param></params></methodCall>

then it's OK.

But if I send the same thing without line breaks:

POST /~fgerlits/livesupport/storageServer/var/xmlrpc/xrLocStor.php HTTP/1.1
User-Agent: XMLRPC++ 0.8
Host: localhost:80
Content-Type: text/xml
Content-length: 1082
<?xml version="1.0"?><methodCall><methodName>locstor.searchMetadata</methodName><params><param><value><struct><member><name>criteria</name><value><struct><member><name>conditions</name><value><array><data><value><struct><member><name>cat</name><value>dc:title</value></member><member><name>op</name><value>partial</value></member><member><name>val</name><value></value></member></struct></value><value><struct><member><name>cat</name><value>dc:creator</value></member><member><name>op</name><value>partial</value></member><member><name>val</name><value></value></member></struct></value><value><struct><member><name>cat</name><value>dc:source</value></member><member><name>op</name><value>partial</value></member><member><name>val</name><value></value></member></struct></value></data></array></value></member><member><name>filetype</name><value>all</value></member><member><name>operator</name><value>or</value></member></struct></value></member><member> <name>sessid</name><value>5095aa18b26b79f292b95d565a0d6c2b</value></member></struct></value></param></params></methodCall>

then it gives the error message I quoted in my previous post.

Thanks, I've reproduced it - interesting ...
Although XML_RPC-1.4.3 is stable, we need downgrade.
I will try to backport solution of empty <value></value> problem to some previous version. (it's trivial change)

BTW. lack of line-breaks is not problem, problem is empty content between some tags. I'm looking for that problematic tag - there may be possible to solve it by small fix, because I've solved yet something similar.

I've patched PEAR XML_RPC module - there was a bug related to solution of our original problem.

Ferenc, please, test it on you system and close the issue if OK.
(on my system it's OK without all unusable whitespaces.)
(there should be sufficient now after update: make -C modules/storageServer pear_install)

Thanks.

Yes, it is OK now.