Thu Dec 22 10:35:48 2005

Ticket #1576

more gcc 4.0 warnings

Priority: normal Reporter: fvanberckel
Severity: minor Assigned to: maroy
Component: development environment Status: new
Version: 1.0.2 Resolution:  
Milestone: 1.1.x Keywords:  

Description by fvanberckel:

Get a error with make -C ./src/modules/core all (make compile)

/home/frans/src/livesupport/svn/trunk/livesupport/usr/include/taglib/id3v1tag.h:56: warning: ‘class TagLib?::ID3v1::StringHandler’ has virtual functions but non-virtual destructor src/AudioClip?.cxx: In member function ‘virtual void LiveSupport::Core::AudioClip?::configure(const xmlpp::Element&)’: src/AudioClip?.cxx:315: warning: ‘attribute’ may be used uninitialized in this function

Attachments

Changelog

Thu Dec 22 12:51:03 2005: Modified by fvanberckel

  • milestone changed from 1.0.2 to 1.0.x
  • version changed from 1.0.2 to 1.0.x

With a make check on core ill get

./tmp/testRunner -o ./doc/testResults.xml -s ../etc/testResultToHtml.xsl writing output to './doc/testResults.xml' using XSLT file '../etc/testResultToHtml.xsl' LiveSupport::Core::UuidTest?::firstTest : OK LiveSupport::Core::UniqueIdTest?::firstTest : OK LiveSupport::Core::AudioClipTest?::firstTestmake: *** [check] Segmentation fault

Thu Dec 22 13:09:52 2005: Modified by fgerlits

  • milestone changed from 1.0.x to 1.1
  • summary changed from AudioClip.cxx: ‘attribute’ may be used uninitialized to more gcc 4.0 warnings
  • version changed from 1.0.x to 1.0.2

Boy, gcc 4.0 sure is picky! I put in some (really unnecessary) initializers, and one more edit in KeyboardShortcut?.cxx (he was right there, the bastard). See commit [1870].

The remaining warnings: 

/home/fgerlits/src/livesupport/usr/include/boost-1_31/boost/config/compiler/gcc. hpp:92:7: warning: #warning is a GCC extension
/home/fgerlits/src/livesupport/usr/include/boost-1_31/boost/config/compiler/gcc. hpp:92:7: warning: #warning "Unknown compiler version - please run the configure  tests and report the results"

--> we don't care. 

/home/fgerlits/src/livesupport/usr/include/taglib/id3v1tag.h:56: warning: ‘class TagLib::ID3v1::StringHandler’ has virtual functions but non-virtual destructor
/home/fgerlits/src/livesupport/usr/include/cppunit/extensions/TestFixtureFactory.h:17: warning: ‘class CppUnit::TestFixtureFactory’ has virtual functions but non-virtual destructor
/home/fgerlits/src/livesupport/usr/include/XmlRpc.h:42: warning: ‘class XmlRpc::XmlRpcErrorHandler’ has virtual functions but non-virtual destructor
/home/fgerlits/src/livesupport/usr/include/XmlRpc.h:60: warning: ‘class XmlRpc::XmlRpcLogHandler’ has virtual functions but non-virtual destructor

--> we don't care (?). 

src/oneshot-reader.c:409: warning: ISO C forbids conversion of function pointer to object pointer type
src/oneshot-reader.c:411: warning: ISO C forbids conversion of function pointer to object pointer type
src/minimal-audio-smil.c:315: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness
src/minimal-audio-smil.c:315: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness
src/minimal-audio-smil.c:320: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness
src/minimal-audio-smil.c:320: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness

(and the same 2 warnings at some 15 more lines; I can provide a list if needed) --> we probably do care.

Thu Dec 22 14:11:39 2005: Modified by maroy

    I'm re-writing gstreamer for 0.10 anyway (for LS 1.1), so I'm not sure if we should spend time on that...

    as for the non-virtual destructor: it will only cause possible reasource leaks. we might want to patch the XmlRpc? library? or see #1467* (we might want to migrate to xmlrpc-c)

    Fri Jan 13 13:27:12 2006: Modified by fvanberckel

      BTW I ll get the oneshot-reader warning even with 3.4 

      make -C ./src/modules/gstreamerElements all
.
.
/usr/bin/gcc-3.4  -g -O2 -DHAVE_CONFIG_H  -pthread -pedantic -Wall -std=c99 -Wno-long-long -fPIC -DPIC -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread -I/home/frans/src/livesupport/svn/trunk/livesupport/usr/include/gstreamer-0.8 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2   -I/home/frans/src/livesupport/svn/trunk/livesupport/usr/include -I./include -I./tmp -c -o tmp/oneshot-reader.o src/oneshot-reader.c
src/oneshot-reader.c: In function `livesupport_one_shot_reader_init':
src/oneshot-reader.c:409: warning: ISO C forbids conversion of function pointer to object pointer type
src/oneshot-reader.c:411: warning: ISO C forbids conversion of function pointer to object pointer type

      Add/Change #1576 (more gcc 4.0 warnings)




      Change Properties






      Action