Thu Apr 28 16:56:33 2005
Ticket #894
integral types and formatting bad in Core::Md5
| Priority: | low | Reporter: | maroy |
|---|---|---|---|
| Severity: | text | Assigned to: | maroy |
| Component: | development environment | Status: | new |
| Version: | Resolution: | ||
| Milestone: | 1.1.x | Keywords: |
Description by maroy:
in the source of the Core::Md5 class, the integral types used are bad, as they assume a certain size without checking. better use uint16_t & the like for fixed sized numbers. also, the code formatting is totally bad in this source :(
Attachments
Changelog
Thu Apr 28 17:59:50 2005: Modified by fgerlits
Fri Apr 29 09:52:11 2005: Modified by maroy
yes, I know. I just still made a mental note, that this can be a source of issues when porting comes about to various platforms. but it's not urgent, therefore I put it to priority low, severity text...
Wed May 4 18:27:50 2005: Modified by fransman
About Mordechai T. Abzug and md5 http://userpages.umbc.edu/~mabzug1/cs/md5/md5.html http://www.advogato.org/article/830.html
Tue Oct 4 16:50:41 2005: Modified by maroy
- description changed.
- component changed from bug to development environment
- milestone set to future
- owner changed from anonymous to maroy
Wed Oct 5 00:22:29 2005: Modified by maroy
- milestone changed from future to 1.1
It is Mordechai T. Abzug's code, with the only difference that most functions are moved from public to private.